search

Moonshine-IDE / Super.Human.Portal

Portal interface to show documentation for DominoVagrant and Super.Human.Installer
Other
0 stars 1 forks source link

Update Bookmarks to Prioritize "Open in Nomad" Action #46

Closed JoelProminic closed 10 months ago

JoelProminic commented 11 months ago

As we move towards using Super.Human.Portal as a customer portal, we we would like to focus on opening the bookmarks in Nomad. Currently, the biggest button is to expand the database details, which is too much information for end users. Instead we would like to have this open in Nomad, and then provide the database details and other actions with a smaller expand button.

I'd like to mockup something for this for the next meeting before we start working on it.

JoelProminic commented 11 months ago

Here is the updated mockup. Let me know if you need more clarification: image

I will need to provide a configuration for this. I'll try to get you something for this and #44 today or tomorrow.

piotrzarzycki21 commented 10 months ago

@JoelProminic I have pushed changes for Bookmarks. I have put edit/delete buttons in a different location - I feel like having them in the right spot would emphasis less Open in Nomad button. Newest build should have all my updates.

JoelProminic commented 10 months ago

We would also like to add an optional description property for the bookmarks, similar to what we have for Installed Applications. This will need to be updated in the Royale form as well as the database and agents. The current plan is to display the description to the right of the collapsed bookmarks.

piotrzarzycki21 commented 10 months ago

We would also like to add an optional description property for the bookmarks, similar to what we have for Installed Applications. This will need to be updated in the Royale form as well as the database and agents. The current plan is to display the description to the right of the collapsed bookmarks.

@JoelProminic I have added description - when you add this to bookmark it will be displayed like that:

Screenshot 2023-11-15 at 11 57 05
JoelProminic commented 10 months ago

I added the defaultAction property. The values are:

Value Behavior
nomad Open with nomadURL. Use this as the default if you get an unexpected value
notes Open with url (Notes client)

This affected several agents:

Agent Updated
CustomBookmarkCreate (response) Confirmed
CustomBookmarkRead (Bookmarks) Confirmed
CustomBookmarkUpdate (response) Confirmed
DatabaseRead (Browse My Server) Confirmed
GenesisInstall Updated code is not directly used
GenesisRead (Installed Apps) Confirmed

To test the "notes" value, create a new ConfigValue document in the Configuration view: Key = link_default_action, Value = notes

piotrzarzycki21 commented 10 months ago

I added the defaultAction property. The values are:

Value Behavior nomad Open with nomadURL. Use this as the default if you get an unexpected value notes Open with url (Notes client) This affected several agents:

Agent Updated CustomBookmarkCreate (response) Confirmed CustomBookmarkRead (Bookmarks) Confirmed CustomBookmarkUpdate (response) Confirmed DatabaseRead (Browse My Server) Confirmed GenesisInstall Updated code is not directly used GenesisRead (Installed Apps) Confirmed To test the "notes" value, create a new ConfigValue document in the Configuration view: Key = link_default_action, Value = notes

This has been handled on UI sight.

JoelProminic commented 10 months ago
Agent defaultAction=notes defaultAction=nomad
CustomBookmarkCreate (response) N/A N/A (CustomBookmarkRead is called first)
CustomBookmarkRead (Bookmarks) Confirmed
CustomBookmarkUpdate (response) Uses original action unless CustomBookmarkRead is called Uses original action unless CustomBookmarkRead is called
DatabaseRead (Browse My Server) N/A N/A (Does not use the expansion logic)
GenesisInstall N/A N/A (GenesisRead is called first)
GenesisRead (Installed Apps) Still using old button logic Still using old button logic

I don't care too much about the CustomBookmarkUpdate case, unless it indicates a bigger problem. We can discuss tomorrow whether Installed Apps should use the updated button code.

JoelProminic commented 10 months ago

From our discussion today, we would like to use the new Bookmark design for Installed Applications as well.

The Description can be moved from the current location to be next to the button, to match #50 : image

piotrzarzycki21 commented 10 months ago

From our discussion today, we would like to use the new Bookmark design for Installed Applications as well.

The Description can be moved from the current location to be next to the button, to match #50 : image

I have changed this in installed application section as well. It's ready for review.

JoelProminic commented 10 months ago

I confirmed the Installed App bookmarks were updated, and the Description is displayed as expected.

There is still a minor issue with defaultAction not updating after a Bookmark is updated. We confirmed yesterday that other properties will be updated using the response from CustomBookmarkUpdate, but not defaultAction.

piotrzarzycki21 commented 10 months ago

I confirmed the Installed App bookmarks were updated, and the Description is displayed as expected.

There is still a minor issue with defaultAction not updating after a Bookmark is updated. We confirmed yesterday that other properties will be updated using the response from CustomBookmarkUpdate, but not defaultAction.

This should be fixed. It's ready for retest @JoelProminic

JoelProminic commented 10 months ago

I confirmed the defaultAction is updated after a CustomBookmarkUpdate. I don't think there are any remaining problems for this issue.