search

Moonsong-Labs / madara-prover-api

RPC server and client to run the Stone Prover on the Madara sequencer.
10 stars 5 forks source link

Feature: execute+prove endpoint #17

Closed odesenfans closed 11 months ago

odesenfans commented 11 months ago

Problem: we want to provide an endpoint that runs a program in proof mode and directly runs the prover on the execution artifacts.

Solution: add a new RPC endpoint that executes and proves the program and returns the proof.

odesenfans commented 11 months ago

Depends on #15.

notlesh commented 11 months ago

Depends on #15.

Another way to handle this is to change the base branch to merge into another PR, e.g. in this case you could have had #17's base branch be od/return-entire-proof-object-from-server (from #15).

It's still a bit messy either way, so I don't care much, just thought I'd point it out.

odesenfans commented 11 months ago

Depends on #15.

Another way to handle this is to change the base branch to merge into another PR, e.g. in this case you could have had #17's base branch be od/return-entire-proof-object-from-server (from #15).

It's still a bit messy either way, so I don't care much, just thought I'd point it out.

Yeah, I haven't found an ideal solution so far. I like the fact that this forces to review bottom up, so you're never reviewing a PR that's on top of an unmerged PR.