Mooy1 / InfinityExpansion

An addon for the plugin Slimefun4
GNU General Public License v3.0
21 stars 60 forks source link

Ingot former doesn't produce correct ingot count when storage only has 1 ingot available to add #103

Open Boomer-1 opened 2 years ago

Boomer-1 commented 2 years ago

Description (Required)

When storing ingots in any storage unit, and 1 ingot is pulled out, the ingot former incorrectly thinks there is enough room to run another cycle of 8 dust to 4 ingots. As it creates the 4 ingots, only 1 actually is created and sent to the storage unit instead of 4. Because there isn't enough room in the storage for the other 4, 3 are deleted instead of remaining in the ingot former.

Steps to reproduce the Issue (Required)

Expected behavior (Required)

the ingot former to either wait until there is enough room to add 4 ingots, or keep the remaining 3 in the machine until there is room.

Server Log / Error Report

none

Environment (Required)

Sefiraat commented 2 years ago

@Boomer-1 Is this still an issue and would you still consider it a bug as opposed to a disliked-feature?

Boomer-1 commented 2 years ago

yes it is a bug still. A few others have reported it as well in discord chat.

Sefiraat commented 2 years ago

Lovely, I’ll take a look shortly :)

JasperChaseTOQ commented 2 years ago

i think wait until there's room for 4 would be best, because otherwise it'll flood cargo and spit the items out