search

Mooy1 / InfinityExpansion

An addon for the plugin Slimefun4
GNU General Public License v3.0
21 stars 60 forks source link

Singularity constructor accepts and converts vanilla copper, and drops slimefun copper when broken. #104

Open Boomer-1 opened 2 years ago

Boomer-1 commented 2 years ago

Description (Required)

Singularity constructors, when receiving vanilla copper will store it towards a singularity. If you break the constructor, it drops slimefun copper ingots.

Steps to reproduce the Issue (Required)

place & power singularity constructor add vanilla copper ingots break constructor. Any ingots stored dropped as slimefun, any vanilla copper still in the left gui spot drops vanilla

Expected behavior (Required)

either vanilla copper to not work in the constructor, or if using vanilla copper, it drops vanilla copper when broken

Server Log / Error Report

none

Environment (Required)

Sefiraat commented 2 years ago

So, this is happening as a by product of IE using infinitylib’s ID/name getter which is linked to to many things at the moment to be replaced without causing more harm than good. I think this only effects copper and composters (composter singularity confirmed). I don’t want to add a manual fix to the machine itself for this one case as I feel it’s relatively harmless. I have made a note in the flaw with the specific method and will fix when I have more of a grounding in the code base. For now this issue will be open for some time.