changed night generation type to darkness

[JasperChaseTOQ]

the energy type night produces energy as long as the light level from the sky is below 15 which can happen anytime of day and not just night and its use is the void panel and that items description is generates energy from darkness and therefore as it doesn't actually relate to night i think its more apt to call it darkness instead of night

[Sefiraat]

While I get your point here, this change doesn't really serve any purpose and the current monikers are more than descriptive enough (given this is dev-facing only) and changing a 'toString()' after this amount of time kinda needs a reason imo. Did you have an extended reason for this?

[JasperChaseTOQ]

i actually did as seen in the screenshot below it actually ends up showing generation night in the void panel and that can be quite confusing because it makes it seem as if it requires night but it doesn't . also i agree completely that it would be descriptive enough if it was dev facing only but it shows up in the void panel and it can confuse people quite easily imo, if im being honest it confused me and its actually what lead me to look at the source code to figure out if it was actually night or how it worked.

[Sefiraat]

Interesting, that toString method showed no usages on IntelliJ, that may be due to lombok however. Either way, the ability to use darkness over night in-game has always felt like a cool additional feature that was discovered by players as opposed to being told about directly, allowing a sense of accomplishment and discovery, now sure I’d want that to change? Though reasoning is much more clear now.

[JasperChaseTOQ]

yeah true i can see your point that its more of a bonus to discover and that it might be better to leave it as is, ultimately its upto you though so if you want to merge or close the pr I'm fine either way