search

MopeSWTP-SS21 / MopeSWTP

MIT License
1 stars 0 forks source link

Codequality #117

Open CSchoel opened 3 years ago

CSchoel commented 3 years ago

I created this pull request prematurely in order to be able to provide a comprehensive code review. This branch is still work in progress.

manuEbg commented 3 years ago

I canceled the workflow because testing already took 1 hour and 50 Minutes. So I think there is something wrong... Maybe @CptKaNe should have a look at this

CSchoel commented 3 years ago

I canceled the workflow because testing already took 1 hour and 50 Minutes. So I think there is something wrong... Maybe @CptKaNe should have a look at this

I have found the culprit: It is actually a NullPointerException, because the executor is not initialized for the ServerIntegrationTest. This raises another issue: Why does GH actions not pick up this error as it happens. I know there is an issue with GH action not recognizing process exits correctly, but I did not think this would be the case for a simple Gradle task.

CSchoel commented 3 years ago

Switched target branch to dev, so that we can actually use this pull request.