Moppu / SecretOfManaRandomizer

Randomizer for Secret of Mana
GNU Lesser General Public License v2.1
6 stars 3 forks source link

Open world: Unable to set xmas gifts < 8 #61

Closed Moppu closed 3 days ago

Moppu commented 1 week ago

Looks like OpenWorldLocationPrizeMatcher.cs is looping through a fixed value of 7 gifts when figuring out dependencies (line 201)

This is throwing an exception when we don't have that many gifts; it should be changed to loop through only how many we defined:

int numGifts = settings.getInt(OpenWorldSettings.PROPERTYNAME_NUM_XMAS_GIFTS);

Also why is this looping until 7, and not including 7? unclear from looking at it why the last prize isn't included in this logic check, so if it's still correct, it should be documented

Moppu commented 3 days ago

fixed by https://github.com/Moppu/SecretOfManaRandomizer/commit/2e01ff4cd6fecf24f906891e53833c83e624cb35