search

MordFIdel / SOCORAD32

ESP32 SOftware COntrolled RADio (SOCORAD32)
161 stars 21 forks source link

Two typos in firmware file. #5

Closed riverside6 closed 1 year ago

riverside6 commented 1 year ago

There are two typos in the firmware file (Arduino_Walkie_Talkie_V223.ino):

Line 1345: "AUDIO VOLUMN:" -> "AUDIO VOLUME:" (except "volumn" appearance as variable and comment) Line 1366: "> waitting..." -> "> waiting..."

MordFIdel commented 1 year ago

'volumn' is a variable and 'volume' is a comment. Is this contrary to your observation?

MordFIdel commented 1 year ago

Your are right about the 'waitting.' But is just used as a string. So should pose no problem. I will correct that anyways.

MordFIdel commented 1 year ago

Thank you so much!

riverside6 commented 1 year ago

It's indeed both not really a problem. Only some minor findings or suggestions. I just wanted to point to the strings that are visible to users, especially as "volumn" is not a correct word. Which of course, as you mentioned doesn't matter for variables and comments.

Thank you so much!

Thank YOU for this great project ;)

joyel24 commented 1 year ago

fixed by this PR https://github.com/MordFIdel/SOCORAD32/pull/8