MordFustang21 / zed-one-dark-pro

Zed One Dark Pro Port
GNU General Public License v3.0
20 stars 7 forks source link

Text selection color is hard to visualize #19

Closed joseluisq closed 2 months ago

joseluisq commented 2 months ago

I noted that when selecting a text, the background color is too dark. Making it easy to lose focus when selecting multiple text occurrences across a file.

For example, note the dark blue selection in zed-one-dark-pro:

image

versus the same selection in a brighter color in VSCode / One Dark Pro which looks much better:

image

Using a bright color should help a lot since the editor's background is already darker.

Suhaybu commented 2 months ago

To add to this issue, when selecting text in documentation, it becomes completely un readable. I will make a PR fix for both of these problems.

CleanShot 2024-08-17 at 02 47 52

edit: Made PR to solve both of our problems https://github.com/MordFustang21/zed-one-dark-pro/pull/20#issue-2471228567