MordFustang21 / zed-one-dark-pro

Zed One Dark Pro Port
GNU General Public License v3.0
20 stars 7 forks source link

Text selection color & opacity fix #20

Closed Suhaybu closed 2 months ago

Suhaybu commented 2 months ago

Problems tackled in this PR

The first issue:

Currently, when selecting code, the color is a blueish color as mentioned in this issue https://github.com/MordFustang21/zed-one-dark-pro/issues/19#issue-2459094338 CleanShot 2024-08-17 at 03 17 26

The second issue:

When selecting text in documentation, the text becomes unreadable. CleanShot 2024-08-17 at 03 18 02

Proposed Solution

By specifying selection color under players, it seems to fix the issue. With my observation, the value selection takes is #<hex_value><opacity> where opacity is the %. So with the color #3e4552 and opacity of 70%, the value expected is: #3e455270

"experimental.theme_overrides": {
  "players": [
     {
      "selection": "#3e455270"
    }
  ]
}

Result of this PR

Resolved first issue:

CleanShot 2024-08-17 at 02 55 37

Resolved second issue:

CleanShot 2024-08-17 at 03 18 33

MordFustang21 commented 2 months ago

This looks great thanks for fixing that.