search

MordFustang21 / zed-one-dark-pro

Zed One Dark Pro Port
GNU General Public License v3.0
19 stars 6 forks source link

Warning text is hard to read #6

Closed MordFustang21 closed 1 month ago

MordFustang21 commented 6 months ago

Should be an easy issue for anyone looking to make a PR with changes to warning, warning.background, and warning.border

image

Ph0enixKM commented 6 months ago

Not only warning. Error text is also hard to read. I think that black text on the bright red would be much more readable.

Zrzut ekranu 2024-03-11 o 17 00 28
Ph0enixKM commented 6 months ago

The same issue applies to info bars

Zrzut ekranu 2024-03-11 o 17 02 45
Suhaybu commented 1 month ago

Should be an easy issue for anyone looking to make a PR with changes to warning, warning.background, and warning.border

Overriding warning.background was not sufficient. I also had to modify hint.background and error.background.

Will make a PR for this.

Edit: Made a PR here: https://github.com/MordFustang21/zed-one-dark-pro/pull/17#issue-2447300516

Suhaybu commented 1 month ago

@MordFustang21 I think we can safely close this issue since the fix was rolled in v0.0.4