feat: add release build compilation

[owittek]

Hey!

Personally I like to compile my nightly builds as a release for performance improvements. For that I have slightly refactored the code to check for this config option and to compile neovim nightly instead of downloading the pre-built binary in case this setting is enabled. It should also work for specific hash installations.

Currently Make has issues with those changes and returns the following:

/Library/Developer/CommandLineTools/usr/bin/make -C build install
[  0%] Built target update_version_stamp
[  4%] Built target nlua0
[ 91%] Built target nvim
[ 91%] Built target nvim_runtime_deps
[100%] Built target translations
[100%] Built target runtime
Install the project...
-- Install configuration: "Release"
Jul 16 22:54:15.055 ERROR Error: No such file or directory (os error 2)

I'll be investigating the cause later today in case this addition is even desired.

EDIT: My current suspicions are:

• Line 274 as it's not cloning with --branch nightly (--branch actually matches tags too)
• Cache issues (see bottom of this section)

[MordechaiHadad]

Looks really nice! what if we add another config property for making self built version, either release or RelWithDebugInfo?

[MordechaiHadad]

@owittek secondly, the error u are getting isn't from make at all, this formatting is from tracing which means an issue with bob

[owittek]

Looks really nice! what if we add another config property for making self built version, either release or RelWithDebugInfo?

Sure, I can look into that if it doesn't already work the way I implemented it

[owittek]

@owittek secondly, the error u are getting isn't from make at all, this formatting is from tracing which means an issue with bob

Makes sense. When this step fails my bob installation is also completely broken. It throws an error on every command that "bob.json could not be found" until I uninstall the failed version.

[MordechaiHadad]

btw @owittek did you fix the issue you got or are you still working on it?

[owittek]

btw @owittek did you fix the issue you got or are you still working on it?

Hey @MordechaiHadad I didn't get to work on this topic, I'll have to debug it when I find the time but feel free to try your luck in the mean time

[MordechaiHadad]

Yeah no problem, I am on a vacation anyway

[owittek]

I managed to debug the error. For some reason this line panics as the file creation fails. Do you have any idea why that could be the case with my changes? This error also happens with a normal nightly installation.

EDIT: My first guess was that it's a relative path issue so I installed my fork with cargo install --git https://github.com/owittek/bob.git but it still happens so I'm out of ideas without going through the entire source code.

[MordechaiHadad]

It seems like this damned file still gives issues, ill try to fix this tomorrow and then u could pull the changes

[owittek]

whoops, upon rebasing I inproperly resolved the merge conflict, will fix later..

[MordechaiHadad]

lol no problem

[owittek]

have you figured out the file issue in the mean-time? I tried debugging it but for some reason even the normal installation in my debugging container failed with the same issue. Is the bob.json just not being created properly?

[MordechaiHadad]

@owittek I havent checked it yesterday kinda got busy with another project, ill try today no promises tho

[owittek]

All good, I have just fixed my merge mistake so the code is actually usable now

[MordechaiHadad]

I pushed a new branch check if this fixes the issue.

[owittek]

I tried it and it works! Feel free to merge this PR after rebasing your fix to main (as your branch has diverged)

[owittek]

=)

[MordechaiHadad]

ill release this tomorrow, thanks for the PR Oli!

[owittek]

I thank you for your cooperation 🫡

[owittek]

Hey @MordechaiHadad have you perhaps forgotten to release? 😁

[MordechaiHadad]

Nah I am just procrastinating, will release it tomorrow hopefully