MordechaiHadad / bob

A version manager for neovim
MIT License
1.45k stars 35 forks source link

Build `RelWithDebugInfo` on windows when building neovim from source #207

Closed MordechaiHadad closed 5 months ago

MordechaiHadad commented 5 months ago

fix #203

sid-6581 commented 5 months ago

@MordechaiHadad this works for me:

        if #[cfg(windows)] {
            if fs::metadata(".deps").await.is_ok() {
                helpers::filesystem::remove_dir(".deps").await?;
            }
            handle_subprocess(Command::new("cmake").arg("-S").arg("cmake.deps").arg("-B").arg(".deps").arg("-D").arg(&build_arg)).await?;
            handle_subprocess(Command::new("cmake").arg("--build").arg(".deps").arg("--config").arg(build_type)).await?;
            handle_subprocess(Command::new("cmake").arg("-B").arg("build").arg("-D").arg(&build_arg)).await?;
            handle_subprocess(Command::new("cmake").arg("--build").arg("build").arg("--config").arg(build_type)).await?;
            handle_subprocess(Command::new("cmake").arg("--install").arg("build").arg("--prefix").arg(downloads_location)).await?;
        } else {

This is essentially what's in neovim's BUILD.md, with -G Ninja removed.

MordechaiHadad commented 5 months ago

Lmao i miss clicked, wanted to respond with "I'll try that"