search

MordechaiHadad / bob

A version manager for neovim
MIT License
1.41k stars 36 forks source link

Fix: rm/uninstall not working when 'v' is missing for neovim versions. #225

Closed matdexir closed 1 month ago

matdexir commented 2 months ago

fixes #224 Let me know what you think!

MordechaiHadad commented 2 months ago

Although this solution seems fine enough, why not switch it to tag_name instead of the non_parsed_string?

matdexir commented 2 months ago

@MordechaiHadad That was actually my first thought but I just left it as is because I was afraid of breaking compatibility with nightly/commit based directories. I am not too sure how they work since I did not dive deep into that part of the code

MordechaiHadad commented 2 months ago

@MordechaiHadad That was actually my first thought but I just left it as is because I was afraid of breaking compatibility with nightly/commit based directories. I am not too sure how they work since I did not dive deep into that part of the code

Fair enough then, fix the clippy errors and done.

Another way is just add

matdexir commented 2 months ago

should be fixed now!