More-Than-Solitaire / Tabs-Lite

An ad-free open source guitar tablature application using an existing popular tabs database. Built for speed and simplicity.
Apache License 2.0
64 stars 4 forks source link

Loading chord F#m results in logcat errors #22

Closed cullub closed 4 years ago

cullub commented 4 years ago

Tapping on a F#m yields logcat errors:

2020-03-31 18:11:54.189 10620-10680/com.gbros.tabslite V/ScopeCoroutine: Fetching url https://api.ultimate-guitar.com/api/v1/tab/applicature?instrument=guitar&tuning=E+A+D+G+B+E&chords[]=F%23m
2020-03-31 18:11:54.189 10620-10680/com.gbros.tabslite D/ScopeCoroutine: Got device id (8514ad823e1da958) and api key (6eb2311192aefcf6c61338baa59d727e)
2020-03-31 18:11:54.329 10620-10680/com.gbros.tabslite V/ScopeCoroutine: Success fetching url https://api.ultimate-guitar.com/api/v1/tab/applicature?instrument=guitar&tuning=E+A+D+G+B+E&chords[]=F%23m
2020-03-31 18:11:54.339 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 2), but no finger (finger= 0).  This shouldn't happen. String= 0, chordName= F#m
2020-03-31 18:11:54.339 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 2), but no finger (finger= 0).  This shouldn't happen. String= 1, chordName= F#m
2020-03-31 18:11:54.339 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 2), but no finger (finger= 0).  This shouldn't happen. String= 2, chordName= F#m
2020-03-31 18:11:54.340 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 2), but no finger (finger= 0).  This shouldn't happen. String= 5, chordName= F#m
2020-03-31 18:11:54.340 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 2), but no finger (finger= 0).  This shouldn't happen. String= 1, chordName= F#m
2020-03-31 18:11:54.340 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 2), but no finger (finger= 0).  This shouldn't happen. String= 2, chordName= F#m
2020-03-31 18:11:54.340 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 2), but no finger (finger= 0).  This shouldn't happen. String= 5, chordName= F#m
2020-03-31 18:11:54.340 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 2), but no finger (finger= 0).  This shouldn't happen. String= 0, chordName= F#m
2020-03-31 18:11:54.340 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 2), but no finger (finger= 0).  This shouldn't happen. String= 1, chordName= F#m
2020-03-31 18:11:54.340 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 2), but no finger (finger= 0).  This shouldn't happen. String= 2, chordName= F#m
2020-03-31 18:11:54.340 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 2), but no finger (finger= 0).  This shouldn't happen. String= 1, chordName= F#m
2020-03-31 18:11:54.340 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 2), but no finger (finger= 0).  This shouldn't happen. String= 2, chordName= F#m
2020-03-31 18:11:54.341 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 9), but no finger (finger= 0).  This shouldn't happen. String= 0, chordName= F#m
2020-03-31 18:11:54.341 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 9), but no finger (finger= 0).  This shouldn't happen. String= 4, chordName= F#m
2020-03-31 18:11:54.341 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 2), but no finger (finger= 0).  This shouldn't happen. String= 1, chordName= F#m
2020-03-31 18:11:54.341 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 2), but no finger (finger= 0).  This shouldn't happen. String= 2, chordName= F#m
2020-03-31 18:11:54.341 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 2), but no finger (finger= 0).  This shouldn't happen. String= 5, chordName= F#m
2020-03-31 18:11:54.342 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 2), but no finger (finger= 0).  This shouldn't happen. String= 2, chordName= F#m
2020-03-31 18:11:54.342 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 2), but no finger (finger= 0).  This shouldn't happen. String= 5, chordName= F#m
2020-03-31 18:11:54.342 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 11), but no finger (finger= 0).  This shouldn't happen. String= 2, chordName= F#m
2020-03-31 18:11:54.342 10620-10680/com.gbros.tabslite E/VarInfo: Chord variation with fret number > 0 (fret= 11), but no finger (finger= 0).  This shouldn't happen. String= 3, chordName= F#m
cullub commented 4 years ago

Same for tabs in or out of favorites. May have to do with the fact that fret 2 is the barred fret in F#m

cullub commented 4 years ago

Chord lookup still works though -- showing it is fine

cullub commented 4 years ago

Also with D, G, and A. Pretty sure it has to do with the bars, since the fret numbers that this is happening on are frets where a variation of the chord has a bar