Carcosa opinion modifier should apply to new contacts

[tzerrell]

Currently only applies to empires you knew when choosing the option.

[tzerrell]

The fix needs testing: run event mem_elusive_carcosa.20 with a planet selected in a save game where you have contact with a fallen empire to test.

[Elimdur]

There is still another problem that just came to my mind. If for example you liberate planets or a primitive civ becomes space faring after you got the modifier, they won´t ever get the "trustworthy" modifier.

on_pre_communications_established = { events = { action.7 action.19 } }

We can do it similar to action 7 to put the modifier on not before known empires. Doing this we can also restore the old mechanic of only giving the modifier to already known countries.

We would also need to set a country flag in case the player chooses this option so we have a chance to trigger the on action correctly.

[Lukasmar]

fe didn't get any opinion modifier. every other empire have opinion modifier

[Elimdur]

Fixed it in dev. Checked if it is working and everything seems to be fine.

Lamil should still take a look at it just to make sure i did not overlook anything.

[tzerrell]

Looks good to me.