Animations Break with LambDynamicLights

MoreMcmeta / core

Animate almost any Minecraft texture with more options. Texture configuration API. 1.16-1.20

GNU Lesser General Public License v3.0

28 stars 5 forks source link

Animations Break with LambDynamicLights #11

Closed nu11une closed 2 years ago

nu11une commented 2 years ago

Describe the bug Having the LambDynamicLights mod installed alongside MoreMcmeta causes MoreMcmeta animations to fail

To reproduce Steps to reproduce the behavior:

Install LambDynamicLights and MoreMcmeta
Install mod/resource pack that uses MoreMcmeta animations
Launch the game and look at the animated textures

Screenshots or videos

Which Minecraft versions does this bug affect?

[ ] 1.16
[ ] 1.17
[x] 1.19 | tested in 1.19, but may be the same in other versions

Mod loader Which mod loaders does this bug affect?

[ ] Forge
[x] Fabric

Mods list MoreMcmeta LambDynamicLights

Resource pack MoreMcmeta Demo

soir20 commented 2 years ago

I've identified the cause of the issue. It seems like a subtle bug in MoreMcmeta and not really an incompatibility--LambDynamicLights simply does additional work during resource loading that reveals a race condition. In any event, it is not a difficult fix, and 3.0.4 should be out within the next few days (need some time to test the fix on all four MC versions).

nu11une commented 2 years ago

Awesome!

soir20 commented 2 years ago

I am merging the other two issues with this one as they are all due to the same root problem. Fixed version should be out later today.

soir20 commented 2 years ago

I released fixed version 3.0.4 on CurseForge last night for 1.19 Fabric; I will be releasing the rest of the fixed versions later today.

soir20 commented 2 years ago

Closing as 3.0.4 for all four versions has now been released to all distribution sites. Thank you for reporting. Please reopen this issue if the problem recurs, or open a new issue if there is another problem.