MoreMcmeta / core

Animate almost any Minecraft texture with more options. Texture configuration API. 1.16-1.20
GNU Lesser General Public License v3.0
28 stars 5 forks source link

better highlighting #4

Closed superon closed 2 years ago

superon commented 2 years ago

Is your feature request related to a problem? Please describe. not a problem as much maybe my eyes just aren't good enough to make out highlighted slots "inventory highlighting"

Describe the solution you'd like make that animated, possibly green/black marching ants bordering the slots would be a lot easier to see.

Describe alternatives you've considered well, i've considered making a resource patch but seems like that's not happening with my skill level.. not even sure it can be done after limited research.

Which Minecraft versions would this feature apply to? Replace the space inside the brackets with an "x" to select a version.

Additional context some resource pack have inventories that are dark so doesn't work well with vanilla highlighting as it seems to work by adding a darker overlay to things that aren't being searched for.. idk but that's what it looks like to me.

soir20 commented 2 years ago

I'm a bit confused... MoreMcmeta doesn't change anything about the game's default inventory. External resource packs you use might, but I don't control those. If you're talking about the MoreMcmeta Demo pack, that's simply meant as an example to help people make their own resource packs rather than add something to the game.

Are you asking for help making an animated resource pack for what you want to do?

superon commented 2 years ago

i don't think it's possible to be done with a resource pack. i'd like to be able to tho so rather than suggesting another mod to handle this i thought i'd post to you, feels like it could be relevant

soir20 commented 2 years ago

I can confirm the highlight color is hardcoded into the game by looking at the inventory code.

Being able to use a texture as the highlight overlay seems like it could be implemented fairly easily, but my initial thought is that it would be better as a separate small mod. Then you could use MoreMcmeta to animate that texture.

soir20 commented 2 years ago

I have this working as a separate tiny mod on both Forge and Fabric. Development is at soir20/InventoryHover. I still need to do some documentation, localization, and cleanup before I release it on CurseForge.

superon commented 2 years ago

fantastic, if available for 1.16 i look forward to utilising this soon :) alternatively if it isn't i look forward to using it in future :) <3 👍

superon commented 2 years ago

oo, also, noting that it's called inventory hover so wondering if my point was slightly missed bc i didn't explain hard enough.. the highlighting i was referring to was that when using jei/rei and double-clicking on the search to highlight everything in open inventories containing the search word/phrase. :/ this may or may not be the same mechanic, idk about all that

soir20 commented 2 years ago

Either way, it gave me an interesting mod idea.

Could you provide a screenshot or video of what highlighting you are referring to? I think I know what you are talking about, but I want to make sure.

superon commented 2 years ago

sure: https://imgur.com/a/GsrDyl1 searching for "rot" here you'll see the top ROTten flesh, carROT, pROTection enchant and pROTea flower are more distinct with highlighting than when using darker resource pack (bottom)

soir20 commented 2 years ago

Thanks for the detailed screenshot!

I think this would be best implemented as a configuration option in the mod that adds search highlighting. An add-on that does what you want is probably going to be hacky, and then you'd also have to download another mod.

You should create a suggestion in the issue tracker of the mod that adds search highlighting. It sounds like the ability to configure the contrast ratio between the light vs. dark search highlighting would resolve the issue you are having. Alternatively, being able to add a texture overlay for the highlighted items would work (and then you could use MoreMcmeta to animate that texture).

Are you using the updated version of More Overlays? The search highlighting feature isn't in JEI, and NEI isn't updated for 1.16. We should pinpoint exactly which mod adds the search highlighting so this issue doesn't bounce around several repositories.

superon commented 2 years ago

np, looks like noone is concerned enough to make this an option for non-latest versions so i'll just call it a lost cause :) still wondering how inventory hover changes things

soir20 commented 2 years ago

Did the mod author say that they did not want to implement it? I'm not sure why you think no one is concerned about it; it is a valid accessibility feature to me. It's just that it works best if it goes into the mod that adds search highlighting in the first place.

InventoryHover allows you to put a texture overlay when you hover over an item in your inventory. There's a config option to disable the default vanilla overlay. Green outline in the video is just the demo texture I'm using.

https://user-images.githubusercontent.com/71418127/147421207-6e441cc7-9e96-4071-8f94-e1a2b0b7fcec.mp4

soir20 commented 2 years ago

Closing for inactivity and since a separate repo for this has already been created