search

MoreMcmeta / core

Animate almost any Minecraft texture with more options. Texture configuration API. 1.16-1.20
GNU Lesser General Public License v3.0
28 stars 5 forks source link

(1.20.1) Stack overflow issue with Dynamic Asset Generator #59

Closed dopa2077 closed 9 months ago

dopa2077 commented 10 months ago

Describe the bug https://github.com/MoreMcmeta/core/issues/18 Same bug as this but for 1.20.1

To reproduce Steps to reproduce the behavior:

  1. Launch the game.
  2. Get stuck in loading screen at "Minecraft Progress"

Expected behavior Game launches normally ?

Screenshots or videos n/a

Which Minecraft versions does this bug affect? i only tried 1.20.1 and multiple force version resulting with the same problem.

Mod loader Which mod loaders does this bug affect?

Mods list

Resource pack n/a

Additional context Logs: https://pastebin.com/AsqtCArr

soir20 commented 9 months ago

Thanks for reporting; it seems like something changed in one of the mods that caused the issue to resurface. I have a general idea of how to fix it; I'll let you know when there's an update.

soir20 commented 9 months ago

MoreMcmeta v4.4.5, which includes a fix for this issue, has been released. It will take a few minutes for CurseForge to approve the files.

I noticed this issue doesn't always happen on 4.4.4, so there seems to be a race condition. Based on my analysis of the stacktrace in the logs and my inability to reproduce it after launching the game ~20 times on 4.4.5, it should be fixed, but it's difficult to confirm 100%. If you encounter it again, please reopen this issue and post logs from the new version.