MoreMcmeta / core

Animate almost any Minecraft texture with more options. Texture configuration API. 1.16-1.20
GNU Lesser General Public License v3.0
27 stars 6 forks source link

Terrible performance with New Default resource pack and Wither Storm mod #71

Open xg787 opened 4 months ago

xg787 commented 4 months ago

Describe the bug horrific performance

To reproduce Steps to reproduce the behavior:

  1. play a mod pack with mod enabled

Expected behavior decent performance

Screenshots or videos without mod 2024-03-02_11 27 38

with mod 2024-03-02_11 30 15

Which Minecraft versions does this bug affect? 1.20.1

Mod loader Forge

Mods list mod list.txt

soir20 commented 4 months ago

Are you using any resource packs? If so, would you please provide them? Performance with MoreMcmeta is usually dictated by the resource packs you're using more than other mods.

xg787 commented 4 months ago

resource packs i use (sorry i did not list them i forgot) Create Re-Created 1.3 Createful Plaques v0.6 Crackers Wither Storm PLUS v4.3 Golden Title Lopy Create Sophisticated Backpacks Lum 5.2 Orders Amulet Two Moons Vanilla Visual Titles xali's Enchanted Books v0.12.0 NewDefault+

soir20 commented 4 months ago

Thanks for providing these. I did notice you have Animatica in your mods list. Both MoreMcmeta and Animatica animate textures, so I'm wondering if they are interfering with each other and creating the performance issue. Can you try removing Animatica and see if that fixes the problem while I take a closer look at your mods and resource packs?

xg787 commented 4 months ago

i tested without Animatica and the performance is about the same

soir20 commented 4 months ago

I'm noticing a fairly significant performance decrease with the CWS Plus and NewDefault resource packs added (from roughly 90-100+ FPS to 40-50 FPS or less on my machine) when a wither storm is active. I don't have any other mods besides Wither Storm and MoreMcmeta.

Can you check whether removing all of your resource packs improves performance? Specifically those two resource packs if you notice an improvement?

Can you also confirm whether you see a performance issue when there is not a wither storm?

xg787 commented 4 months ago

when i removed CWS Plus and NewDefault i got 35~ fps with a storm

without any resource packs i get 40~ fps with a storm

with all my resource packs i get a 35~ with no storm

soir20 commented 4 months ago

Thanks for confirming. It seems like most of the performance difference is explained by these two resource packs, but there might be another mod in your mod pack that MoreMcmeta isn't performing well with. (It's not a general issue with all mod packs.) I'll need to do some testing with your mods list.

soir20 commented 3 months ago

I've done some more testing. Here is what I've found so far:

Can you please test these situations and report what FPS you get?

I suspect the problem is an interaction between the additional rendering checks from the emissive plugin and all the block updates from the Wither Storm mod.

xg787 commented 3 months ago

did some testing with modpack and with resource pack: 2024-03-21_20 16 59

with modpack and without resource pack: 2024-03-21_20 20 26

only mcmeta, witherstorm, vanilla render and with resource pack: 2024-03-21_20 27 54

only mcmeta, witherstorm, vanilla render and without resource pack: 2024-03-21_20 28 13

soir20 commented 3 months ago

Thanks for the additional info. To clarify, which mods did you remove when you say "vanilla render"? Did you include the emissive plugin in all four cases?

xg787 commented 3 months ago

when i mean vanilla render is no embeddium or performence mods of any kind and no i did not have emissive plugin in all cases and in the last 2 cases i only had the wither storm mod and more mc meta core with no other mods