search

MoreMcmeta / core

Animate almost any Minecraft texture with more options. Texture configuration API. 1.16-1.20
GNU Lesser General Public License v3.0
27 stars 6 forks source link

NeoForge port #72

Open Lolothepro opened 4 months ago

Lolothepro commented 4 months ago

Is your feature request related to a problem? Please describe. I want to use this mod with NeoForge

Describe the solution you'd like That I can use it

Which Minecraft versions would this feature apply to? 1.20.4

soir20 commented 4 months ago

It looks like the reason MoreMcmeta isn't loading in NeoForge is because of the Forge version number:

[15:50:59] [main/ERROR]: Missing language javafml version [47,) wanted by gui-plugin-forge-1.20.1-1.0.1-forge.jar, found 2.0
[15:50:59] [main/ERROR]: Missing language javafml version [47,) wanted by properties-parser-plugin-forge-1.20.1-1.1.5-forge.jar, found 2.0
[15:50:59] [main/ERROR]: Missing language javafml version [49,) wanted by emissive-plugin-1.20.4-2.0.4-forge.jar, found 2.0
[15:50:59] [main/ERROR]: Missing language javafml version [49,) wanted by moremcmeta-1.20.4-4.4.7-forge.jar, found 2.0
[15:50:59] [main/ERROR]: Missing language javafml version [47,) wanted by texture-plugin-forge-1.20.1-1.0.1-forge.jar, found 2.0
[15:50:59] [main/ERROR]: Missing language javafml version [47,) wanted by animation-plugin-forge-1.20.1-1.0.3-forge.jar, found 2.0
[15:50:59] [main/ERROR]: Missing language javafml version [47,) wanted by json-parser-plugin-forge-1.20.1-1.1.1-forge.jar, found 2.0

I may be able to remove the Forge version requirement for newer MC versions to get it to load with NeoForge.

It's a lot of work for me to support a new mod loader, mainly from a testing perspective. If that were to happen, support for older MC versions would need to be dropped. The reason there has been no official decision on what to do about NeoForge is that I've been waiting to gauge how much of the community moves over. Hopefully, the short-term fix is simple, and I can figure something out over the long term as NeoForge and Forge most likely diverge.

soir20 commented 3 months ago

Unfortunately, the simple solution doesn't look like it's going to work. I think the best solution is to drop active support for 1.16-1.18, and possibly 1.19.4, and then create a Neoforge port. These versions are significantly less popular than 1.19.2, 1.20.1, 1.20.2, and 1.20.4 based on download counts. MoreMcmeta also hasn't needed to update much recently, so the current versions should be pretty stable even if they aren't updated anymore.

I will write up a more complete post once I've decided for sure what versions won't be in active support anymore and what dropping "active support" means.

Since this is an issue with MoreMcmeta core as well, I'll transfer this over to that repository.