MoreMcmeta / core

Animate almost any Minecraft texture with more options. Texture configuration API. 1.16-1.20
GNU Lesser General Public License v3.0
28 stars 5 forks source link

Texture is stuck on frame 1. #9

Closed googlescientificnameforapig closed 2 years ago

googlescientificnameforapig commented 2 years ago

Describe the bug A clear and concise description of what the bug is. The texture is either black or stuck on frame #1. Frame no 1 is black.

To reproduce Steps to reproduce the behavior:

  1. Put on my texture pack
  2. Add the mod 'cit resewn, moremcmeta'
  3. rename a redstone torch to: "Oh no"

Expected behavior An animated rick roll

Screenshots or videos If applicable, add screenshots or videos to help explain your problem. image

Which Minecraft versions does this bug affect?

Mod loader Which mod loaders does this bug affect?

Mods list What mods are you using?

image

Resource pack What resource packs are you using? Please link to them or attach them to this issue. LOLXD.zip

Additional context Add any other context about the problem here.

soir20 commented 2 years ago

Thanks for attaching the pack and screenshot in your report!

I've identified the cause of the issue. It is a minor incompatibility between MoreMcmeta and CIT Resewn. In short:

IMO, it's a simple enough fix on MoreMcmeta's end to do checks with and without the suffix and handle edge cases like this that might show up in other mods. The additional check can be performed efficiently. I may not be able to release a new version until the weekend since I would want to test the new changes.

soir20 commented 2 years ago

Fixed versions have been released on CurseForge, Modrinth, and GitHub.