search

MoreMcmeta / emissive-plugin

Plugin for MoreMcmeta to enable emissive textures for blocks, items, entities, and block entities.
GNU Lesser General Public License v3.0
4 stars 0 forks source link

Unable to find texture #20

Closed Krimatoria closed 7 months ago

Krimatoria commented 8 months ago

Describe the bug [25Feb2024 01:31:41.522] [Render thread/ERROR] [io.github.moremcmeta.moremcmeta.impl.client.MoreMcmeta/]: Unable to find texture minecraft:textures/particle/sga.png (referenced by minecraft:optifine/emissive.properties) [25Feb2024 01:31:41.523] [Render thread/ERROR] [io.github.moremcmeta.moremcmeta.impl.client.MoreMcmeta/]: Unable to find texture supplementaries:textures/blocks/end_lamps/end_stone_lamp.png (referenced by minecraft:optifine/emissive.properties)

To reproduce supplementaries-1.19.2-2.4.20.jar

Expected behavior Log Spam

Screenshots or videos

Which Minecraft versions does this bug affect? Minecraft 1.19.2

Mod loader Which mod loaders does this bug affect?

Mods list moremcmeta-1.19.2-4.4.7-forge.jar emissive-plugin-1.19.2-2.0.4-forge.jar

Resource pack

Classic+Emissive+Ores.zip classic-emissive-ores-1-19-2.zip - Optifine default-emissive-v3-0-0.zip - Optifine

EclecticTrove-1.19.2-1.3.0.zip FNQuestingResources.zip immersive 1.19.zip Pixelated_v1.3.2_EnhancedVisuals(nox_cgt).zip Quark Programmer Art.zip Repurposed_Structures-Better_Desert_Temples_v7.zip Repurposed_Structures-Better_Dungeons_v4.zip Repurposed_Structures-Better_Jungle_Temples_v1_4.zip Repurposed_Structures-Better_Monuments_v5.zip Repurposed_Structures-Better_Nether_Fortress_v5.zip Repurposed_Structures-Better_Strongholds_v4.zip Repurposed_Structures-Better_Witch_Huts_v3.zip Repurposed_Structures-Hexerei_v5.zip Tarot Cards Colorized 1.19.2.zip The Graveyard - Terralith Compatability.zip Aether Regenerated v1.1.2.zip Alagard Font.zip All Glowing + 3.0.zip Alternative Rain Sounds 1.19-1.19.2.zip Ashen_1.4.3_1.19.2.zip Ashen_Simple_Foliage_FN_0.2.zip boss-refreshed-v.1.1.1.zip cassette music discs 1.19 - 1.19.2 v1.2.zip

Additional context Add any other context about the problem here.

soir20 commented 7 months ago

Thanks for reporting. This is an issue with the emissive plugin, so I'm going to transfer this issue to that repository.

I'm not sure if this is fixable, though. The reason it happens is that there are minecraft:textures/particle/sga_e.png and supplementaries:textures/blocks/end_lamps/end_stone_lamp_e.png textures. Because your emissive resource pack is configured with suffix.emissive=_e, MoreMcmeta looks at all textures ending with _e to check if they are emissive.

There's no general way to say whether a texture ending with _e is supposed to be emissive or not for MoreMcmeta to skip the log message. The alternative is to not print any log statements when a texture isn't found, but that makes it harder for resource pack creators to debug issues with their packs.

soir20 commented 7 months ago

I've taken another look at this, and I don't think there's a way to prevent the log spam without making life more difficult for resource pack developers. The log spam in this case does not seem so bad that it outweighs resource packs being more difficult to debug.

I think the potential solutions would be lowering the severity of the message (perhaps from ERROR to WARN) or changing the message itself. I'm going to close this issue as "won't fix" for now, but please feel free to reopen it if you find the log message confusing/distracting and think one of those two solutions would help.