Morgan243 / python-on-a-chip

Automatically exported from code.google.com/p/python-on-a-chip
Other
0 stars 0 forks source link

Make GC mark frame stack correctly #190

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Oscar reported via private email on 2011/02/19 a test case that shows that the 
GC is not correctly marking the contents of the frame's stack.  I traced the 
cause of the problem to the change I made for #174.  I need to revert that 
change in heap.c and find a proper fix for test t374.py

Original issue reported on code.google.com by dwhall...@gmail.com on 24 Feb 2011 at 2:42

GoogleCodeExporter commented 8 years ago
The problem with t374.py was that when the GC ran immediately before a call to 
a native function (interp.c:1985), the gVmGlobal.nativeframe.nf_active was not 
set TRUE so the arguments to the native function were not marked.

The fix was to move the line that sets gVmGlobal.nativeframe.nf_active to TRUE 
to be before interp.c:1985.

Original comment by dwhall...@gmail.com on 24 Feb 2011 at 3:52

GoogleCodeExporter commented 8 years ago
This issue was closed by revision 19678b7e9d.

Original comment by dwhall...@gmail.com on 24 Feb 2011 at 4:21