[REQUEST] Allow cells to be disabled

MorganGrundy / MosaicMagnifique

Application for generating Photomosaics. Turn your images into beautiful Photomosaics.

https://morgangrundy.github.io

GNU General Public License v3.0

14 stars 0 forks source link

[REQUEST] Allow cells to be disabled #3

Closed MorganGrundy closed 4 years ago

MorganGrundy commented 4 years ago

Describe the solution you'd like I want to be able to disable some of the cells in the Photomosaic grid. When disabled they could be replaced with the background.

You should be able to click on each cell to toggle it. Could be able to change on grid preview and final Photomosaic

MorganGrundy commented 4 years ago

Cell best fits are affected by grid state, due to repeats. This means that any time grid state changes (when repeat options are in use) the entire Photomosaic would need to be regenerated for a consistent result.

If grid state can be fully changed from the final Photomosaic then we would need to either:

Initially generate best fit for every single cell, even the disabled ones.
Initially generate best fit for only enabled cells, and then allow for newly enabled cells to be generated retrospectively.

MorganGrundy commented 4 years ago

Possible solutions:

Generate best fits for every possible cell regardless of grid state, then user can freely modify grid state of final Photomosaic. Problems: When repeats are used this would affect the results slightly; Significant impact on performance, scales with number of size steps.
Generate best fits for only enabled cells. With the final Photomosaic allow the user to freely disable cells, but enabling cells will require regenerating. Problems: When repeats are used and cells are disabled at final Photomosaic the results are slightly affected
Only allow grid state to be modified before generating Photomosaic, final Photomosaic cannot be modified. Problems: None?

MorganGrundy commented 4 years ago

Partial grid editing added: 2384cd0fa659fef2ada683fde08d972a81f593e0, d8e586591fd093ce2a33b0041dbef31e19561dbf Currently only the highest step size can be edited.

MorganGrundy commented 4 years ago

Full grid editing added: 180cb03cb7bc33511f8106b600c7d1456ce1da9e

Grid editing can be improved with:

[x] Add a tool for editing all cells in a range (clicking on each cell can take long).
[x] As grid size increases the time for each click increases. Should store cells in quadrants to reduce number of cells to check per click.

MorganGrundy commented 4 years ago

Grid editing now uses a quadtree for slightly better performance: 9bf0bfa7d8b3647cd3ec44be7369f3ab8d52bbed

MorganGrundy commented 4 years ago

Added selection tool for grid editing: 48b41eb28dc5a7e11eb3fbeb3f8c1416ccd91888