MorganLevineLab / methylCIPHER

21 stars 9 forks source link

Number of stated Knight clock CpGs is 1, should be 148 #4

Open rauldiul opened 1 year ago

rauldiul commented 1 year ago

Hi! Thanks for your useful tool.

I've noticed that when you run getClockProbes(exampleBetas) in your Readme, or running it with custom betas after installing the package, the output says that the Knight clock has only 1 Total.probes.

However, this clock uses 148 CpGs. Internally, with get("Knight_CpGs") I can see that there are 148 CpGs. There seems to be a problem with the getClockProbes function, where you define totalProbes[i] <- length(currentCpGList), in the case of "Knight_CpGs", the currentCpGList object is a tibble with 1 column, and thus length is 1.

hope this helps

best