search

Morikko / sync-tab-groups

Sync Tab Groups is an easy way to manage all your tabs. You organize them depending on a topic by group. Groups can be closed and reopend without caring about your session. Moreover, you can esily search, active, move, save and remove your groups and tabs.
MIT License
147 stars 18 forks source link

add a translation to zh_TW. #102

Closed rzfang closed 6 years ago

rzfang commented 6 years ago

Goal

support zh_TW.

Detail

Morikko commented 6 years ago

Hi rzfang,

Can you remove the translations kept in English ?

If a translation is not present, it falls back automatically to the English file ;)

Thank you for your work

rzfang commented 6 years ago

done. please review. thanks.

Morikko commented 6 years ago

Thank you, very well job :+1: It will be in release 0.6.5

Morikko commented 6 years ago

Just for curiosity did you use this tool I provided in the README.md ?

rzfang commented 6 years ago

Don't understand your question. If you asked about Did I use the dev version, my answer is NO, and I just copied the file and translated the wordings what I was sure. If you aksed about Am I using this extension, my answer is YES. The firefox 57 issue, you know.

Morikko commented 6 years ago

No sorry for the confusion, I provided a link to an online tool in my last comment. It is a tool I created to make translation easier.

I just wanted to know if you used it or if you changed it with a text editor. I am looking for feedback, that is the reason.

You can find some links also in the README, translation section.

Le mar. 3 avr. 2018 à 07:48, RZ notifications@github.com a écrit :

Don't understand your question. If you asked about Did I use the dev version, my answer is NO, and I just copied the file and translated the wordings what I was sure. If you aksed about Am I using this extension, my answer is YES. The firefox 57 issue, you know.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Morikko/sync-tab-groups/pull/102#issuecomment-378135598, or mute the thread https://github.com/notifications/unsubscribe-auth/AHeAFEAdALVHLI1wKRULCsaWXeZoMnPnks5tkw1DgaJpZM4TCvT_ .

rzfang commented 6 years ago

The tool link you gave is https://github.com/Morikko/sync-tab-groups ???

And the README New language link is https://morikko.github.io/translate-web-extension/translate?headoriginal=https://github.com/Morikko/sync-tab-groups/blob/master/extension/_locales/en/messages.json I got 404 in the first time, after I cut the url to be https://morikko.github.io/translate-web-extension, then each time I can get a fine page. weird...

Now I know the tool, will use it. Thanks, this really helps.

Morikko commented 6 years ago

I provided the wrong link for the tool :sob: Glad you find the good one in the README.

I understand the 404. Surprisingly, it works well on normal window but not in private window on my computer. In private window:

  1. I can't fetch /translate directly https://morikko.github.io/translate-web-extension/translate
  2. I should go first to https://morikko.github.io/translate-web-extension and next click to translate button

Sometimes other people complained it was down, but I not sure it is the 404 error. Maybe, it could be a Github limitation. Someone else also opened an issue.

Morikko commented 6 years ago

I found a solution to 404. :tada:

Normally, it is fixed. I can reach it directly from private windows. You can try it again with the links in the README.