Tab Groups Don't Survive A Restart

[Lcstyle]

If Multiple Windows Exist and are labeled with Tab Group names, after restarting FF 57.0.2 browser, the windows are recreated, but the Tab Groups are no longer in sync with the Windows that firefox recreates that restore those tabs. In other words at least in my use case ( I don't understand all the tab group use case paradigms, so not sure if tab groups equate to specific windows ), my tab groups have a 1:1 relationship with open firefox Windows. When the windows are restored by FF after restarting, the Tab Groups still exist (they are still available for me to click on), however, when I do, sync tab groups creates a new window with all the tabs, not realizing that the same window with all the existing tabs already exists and was opened previously by FF. Basically, I am simply looking to have sync tab groups recognize / relabel the tab groups in the restored FF windows.

I think this is a feature request to simply have sync tab groups reattach it's defined tab groups to restored windows after a restart.

[Lcstyle]

Here's what the end result looks like after restarting FF

[Morikko]

Got it, it should behave like you are expecting. There is a problem that I am also facing. I am believing it is on the start.

Now, I believe event can be triggered before initialization are finished. So, it might disturb initialization:

• Window are not retrieved well (your case)
• Groups are lost (@elizabethsimon)

I might have missed it as I am doing my test on an alternative session where I have few groups with few tabs for convenience. However, the problem of synchronization might occur more often when the computer is slow (many groups and tabs to init and a big Firefox session to restore).

I am changing the code to fix it and reinforce it. I will try some violent test of restarting to see if it seems better. However, as it doesn't happen at each case, I will have no guarantee. I will also send a notification to ask the users to export groups regularly for limiting risk.

[Lcstyle]

Thanks for the response. I will add just one comment, I think once a window is "labeled", no matter what tabs in it are closed or opened, when the browser is restarted and that window is restored, it's label should come back. I don't know enough about firefox extensions to determine if it is possible to keep track of labeled windows across restarts. But that would seemingly fix the issue.

[Morikko]

Si si si, it is like this and it works most of the time. It finds back windows after Firefox restarting and if you disable/enable the extension.

However, if you uninstall the extension it won't, as the data of the extension is removed!

What happened to you is a bug.

2017-12-12 15:49 GMT+01:00 LC notifications@github.com:

Thanks for the response. I will add just one comment, I think once a window is "labeled", no matter what tabs in it are closed or opened, when the browser is restarted and that window is restored, it's label should come back. I don't know enough about firefox extensions to determine if it is possible to keep track of labeled windows across restarts. But that would seemingly fix the issue.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Morikko/sync-tab-groups/issues/44#issuecomment-351073167, or mute the thread https://github.com/notifications/unsubscribe-auth/AHeAFDBOCLWcAgmw5FHG2R7-2grcjBXRks5s_pKCgaJpZM4Q-Sdp .

-- Eric

[Morikko]

I submitted v0.4.1. As I said, I fixed the behavior so every actions wait the initialization of the extension. I hope it was the problem.

In developer mode, extension is disabled at each restart. That was also why I didn't test it much. I found a method to keep it open. However it is only in Firefox developer browser so the version 58 (might have better start performance...⁾.

In this case, I tested 2 types of restart:

• Soft: I quit and reopen
• Hard: I kill FF and reopen

In both cases at each time (and many times), I find back the associated windows, unassociated windows, and all the groups. I had > 15 groups and > 100 tabs, > 3 windows opened and associated and 1 window opened and unassociated.

Those good results were for:

• v0.4 (yes, surprisingly)
• v0.4.1 (hoping in any cases it fixes the rare cases when it happened)

---

When you will update to v0.4.1, let me know if you have again problem. I also had the same problem than @elizabethsimon this afternoon on my real FF session (FF just restarted). I will keep an eye.

Sorry for the disturbance.

[Lcstyle]

@Morikko, sir, you are the master. Works beautifully. I showed this extension to a friend, he immediately was like wow (jaw drop).

Anyways, I forgot to say thank you, it works perfect now. Feel free to mark as resolved and close.

[Morikko]

I am glad it looks better. I will close this issue, if you have any new problem, open it again.

cheers