Morikko / sync-tab-groups

Sync Tab Groups is an easy way to manage all your tabs. You organize them depending on a topic by group. Groups can be closed and reopend without caring about your session. Moreover, you can esily search, active, move, save and remove your groups and tabs.
MIT License
147 stars 18 forks source link

Tab hiding support #64

Closed hdd60311 closed 6 years ago

hdd60311 commented 6 years ago

A preliminary support for it has been added in firefox 59. https://bugzilla.mozilla.org/show_bug.cgi?id=1423725

Morikko commented 6 years ago

I will check soon !

hdd60311 commented 6 years ago

Any news about this?

Morikko commented 6 years ago

I started work on this. It will land before FF59 becomes a stable release (Mid-March).

There will be 2 modes:

saleem-git commented 6 years ago

Hi, The add-on still reloads the tab when I switch between groups. Firefox gave me this add-on https://t.co/x1Hm0751a8, it just a concept add on but it hides and un-hides tabs without realoading them.

Morikko commented 6 years ago

I am still on this, however I prioritized stability last days. When a version will be available, I will create a beta for test. I will need help from you for this.

peci1 commented 6 years ago

Let me know then, I'll join the beta tests. Thanks!

OdinGitDat commented 6 years ago

Any ETA on this?

Morikko commented 6 years ago

I have been able to hide/show a group and it's pretty fast!

Also, a bad news, FF doesn't allow to discard tabs that has a before unload event. And, websites often use it. See 1420681 - Add forceDiscard property to tabs.discard

Morikko commented 6 years ago

hidden_tabs

peci1 commented 6 years ago

Like at the old times with Panorama!

Morikko commented 6 years ago

Last news on April 15th

Morikko commented 6 years ago

Finally, the first version is available (v0.7-alpha). It is NOT a final release, so bug can still appear:

For avoiding those problems, you might test it on another profile that will be completely unrelated to your current session.

Read carefully the hiding documentation before trying it. Also, you need to activate the hiding option in Firefox.

Installation step:

  1. xpinstall.signatures.required preference in about:config should be set to false
  2. Download the XPI file
  3. On the top bar in Firefox select: File > Open A File
  4. Select the XPI file and accept the installation

I am waiting for all your feedback. :smiley: :+1:

peci1 commented 6 years ago

Thanks. The xpinstal.signatures.required option is only available in Firefox developer edition. In regular firefox, you need to sideload the addon via about:debugging.

peci1 commented 6 years ago

Otherwise I haven't noticed any problems so far (except the addon opening two tabs whose content cannot be loaded right after activation).

The tabs are:

moz-extension://ea27fc28-4df4-41ac-9a8d-7f02af900a47/tests/test-page/integration.html
moz-extension://ea27fc28-4df4-41ac-9a8d-7f02af900a47/tests/test-page/unit.html
Morikko commented 6 years ago

Thank you @peci1, the tabs contain the tests but I removed them from the package when I pack the extension. They open when you update/reload the extension and the version number stays the same.

Anyone else tested it ?

Morikko commented 6 years ago

Experimental API in the next release :+1:

UnstableStranger commented 6 years ago

I like your extension a lot so thanks for making it and continuing to work on it.

When I click a link it creates a new tab group. For example: I am in Reddit group and click a link in the bookmarks toolbar it opens in a new tab group. Shouldn't it open in the same tab group?

Morikko commented 6 years ago

Since Firefox 61, it is an official feature. So, I close the issue as it is also well implemented.