Morisset / pySSN

Pythonic Spectral Synthesis for Nebulae
Other
4 stars 2 forks source link

Adding an editing box for the instrumental profile #31

Open Morisset opened 5 years ago

Morisset commented 5 years ago

The instrumental profile is now accessible via the variable "prof" in the parameters (may be changed to "instr_prof"?) AND by reading a file named via the "fic_instr_prof" variable. This is confusing. Better do the same than for the continuum: adding some editing popup window that allows to change the 17 parameters, perhaps in the form:

'HWHM Gauss': [one box for the value] 1 (Bl, Br, decreasing, alpha) : [one box for 4 values] 2 (Bl, Br, decreasing, alpha) : [one box for 4 values] 3 (Bl, Br, decreasing, alpha) : [one box for 4 values] 4 (Bl, Br, decreasing, alpha) : [one box for 4 values]

The values would be saved with the save_parameters facility, and no more need for the fic_instr_prof file.

mvfcopetti commented 5 years ago

Ok. I will do it.

mvfcopetti commented 5 years ago

It is done. I writing a help but the instrumental profile is the most difficult task to explain. Too many parameters. Do you mind if I change the name of some of the parameters, e.g. largeur for width (or fwhm)? I could make the number of parameters not fixed as well.

Morisset commented 5 years ago

Great! HWHM would be great. I think 4 parameter sets is enough. Thanks a lot.