search

MoritzS / jinja2-django-tags

jinja2 extensions that add django tags
MIT License
41 stars 10 forks source link

Django4.0 compat #15

Open imLew opened 5 months ago

imLew commented 5 months ago

fixes #14

MoritzS commented 5 months ago

Thanks for the pull request!

Sorry, I'm not active in Django development anymore. Can you update the README and the tox.ini so that they don't reference unsupported Django versions anymore? I think #11 did some of that.

imLew commented 5 months ago

I'm not familiar with tox, so I had to guess that this is how python 3.12 would be included and I've changed to django 4 and 5 and jinja 3.1.

I hadn't noticed tests.py before and ran it now, a bunch of seemingly unrelated tests do fail in my local env with (python 3.12, django 4.2.8 and jinja 3.1.3). I don't have time to fix those, so maybe this PR should be closed. On the other hand these changes certainly aren't the reason and with them jdj-tags can be used with django 4.