search

MoriyaShiine / enchancement

A Minecraft mod that completely overhauls the vanilla enchanting system.
https://modrinth.com/mod/enchancement
47 stars 30 forks source link

Compatibility with Enchantery 1.20 #124

Closed lxly9 closed 1 week ago

lxly9 commented 1 year ago

Mod version

1.20-6

A description of the issue

Enchancement and Enchantery are sadly not compatible due to a bug in the enchanting table as described below.

When using enchancement with enchantery and 'enchanting table overhaul' is off while 'single level mode' is turned on in the config, the enchanting table does not produce the described enchantments in the table. Even if books are put in chiseled bookshelves or using soul torches to influence the outcome the described enchantments are not applied and apply a 'base enchantment' (in case of armor its protection, for weapons sharpness and tools efficiency). It would be great if we got some compatibility between the two mods as enchancements enchantments are a game changer haha

Log or crash report

https://gist.github.com/lxly9/de10cb7a1d7b1905cbbe1a562ba43686

MoriyaShiine commented 1 year ago

Enchancement removes Protection and Sharpness by default, try enabling them and seeing if it works

lxly9 commented 1 year ago

i will try that!

lxly9 commented 1 year ago

hmm, after testing (and falling asleep lolol) it behaves the same way still

MoriyaShiine commented 8 months ago

Is this still an issue? I'm not sure what to do with it lol

lxly9 commented 8 months ago

I will check again today, I do believe it is still one but I hope not haha

lxly9 commented 8 months ago

huh, still the same issue sadly, it appears to be scooping (when a scooping book in a chiseled bookshelf in the vicinity) in the enchanting table, but when clicked on its efficency

MoriyaShiine commented 1 week ago

I've completely rewritten the disallowed enchantments system in the upcoming update, so I'm not sure if this will still be a problem. If it is, I'm not really sure what I would do about it