search

MoriyaShiine / enchancement

A Minecraft mod that completely overhauls the vanilla enchanting system.
https://modrinth.com/mod/enchancement
48 stars 30 forks source link

Unable to add compatibility for BCLib ores #70

Closed SplendidAlakey closed 1 year ago

SplendidAlakey commented 1 year ago

Mod version

1.19-7

A description of the issue

I made a datapack to make Extracting enchantment work with BCLib mods' ores, based on the pinned example from Discord, adding modded ores from BetterNether and BetterEnd, but none worked. The datapack itself works, because I tried it with another mod, Expanded Delight, which worked perfectly file. So it has something to do with BCLib mods specifically.

Here's the pack: test.zip

Log or crash report

https://gist.github.com/SplendidAlakey/19350f45302bffb6966dd37c4a50f30f

MoriyaShiine commented 1 year ago

Ores also need to be in the c:ores tag (the general ores tag) in order for extracting to pick up on it. I've attached a fixed datapack, but I suggest asking the devs of BetterNether and BetterEnd to add their blocks to that tag.

ores.zip

SplendidAlakey commented 1 year ago

Oh, forgot to mention and do this on the test instance, but I did add the tag via KubeJS. Will check again + with the fixed pack in a minute.

SplendidAlakey commented 1 year ago

Apologies for a delayed response. The fixed version of the datapack also doesn't work. But I don't believe this is the issue with your mod, anyway, because I checked with F3+H and the tags were absent, despite the datapack being active. KubeJS does add the tag, on the other hand, but something still goes wrong. I suspect BCLib mods will have to add it natively.

Thanks for the reply, though, and sorry for wasting your time!