search

Morlok8k / MinecraftLandGenerator

Pregenerate Land in a SMP Minecraft Server
http://www.minecraftforum.net/topic/187737-minecraft-land-generator/
Do What The F*ck You Want To Public License
97 stars 20 forks source link

Aggressive force-stop issue with [WARNING] lines in log #15

Closed VADemon closed 5 years ago

VADemon commented 5 years ago

Server version: 0.2.1 for Minecraft Alpha 1.1.2

When server is set to online-mode=false (auth servers no longer work!), MLG force-stops because it finds a warning in the log output.

Two issues at hand:

  1. A non-critical warning shuts down MLG (to prevent damage - but there should be a way to exempt this warning
  2. Since the server writes 4 lines with [WARNING], MLG tries to stop the server FOUR times in the same run.

Good first issue

1) Make a whitelist of warnings 2) Only send the stop/save-all command ONCE per run, not every time there's a new [WARNING] line.

[Server] Starting minecraft server version 0.2.1
[MLG]
[MLG] Warning found: Stopping Minecraft Land Generator
[Server] 2019-04-21 21:17:01 [WARNING] **** SERVER IS RUNNING IN OFFLINE/INSECURE MODE!
[MLG]
[MLG] Forcing Save...
[MLG]
[MLG] Warning found: Stopping Minecraft Land Generator
[Server] 2019-04-21 21:17:01 [WARNING] The server will make no attempt to authenticate usernames. Be
ware.
[MLG]
[MLG] Forcing Save...
[MLG]
[MLG] Warning found: Stopping Minecraft Land Generator
[Server] 2019-04-21 21:17:01 [WARNING] While this makes the game possible to play without internet a
ccess, it also opens up the ability for hackers to connect with any username they choose.
[MLG]
[MLG] Forcing Save...
[MLG]
[MLG] Warning found: Stopping Minecraft Land Generator
[Server] 2019-04-21 21:17:01 [WARNING] To change this, set "online-mode" to "true" in the server.set
tings file.
[MLG]
[MLG] Forcing Save...
[MLG] 95%...
[Server] Done
[MLG] Saving server data...
[MLG] Stopping server...  (Please Wait...)

Server.log:

2019-04-21 21:17:01 [INFO] Starting minecraft server version 0.2.1
2019-04-21 21:17:01 [INFO] Loading properties
2019-04-21 21:17:01 [INFO] Starting Minecraft server on *:25565
2019-04-21 21:17:01 [WARNING] **** SERVER IS RUNNING IN OFFLINE/INSECURE MODE!
2019-04-21 21:17:01 [WARNING] The server will make no attempt to authenticate usernames. Beware.
2019-04-21 21:17:01 [WARNING] While this makes the game possible to play without internet access, it also opens up the ability for hackers to connect with any username they choose.
2019-04-21 21:17:01 [WARNING] To change this, set "online-mode" to "true" in the server.settings file.
2019-04-21 21:17:01 [INFO] Preparing level "world"
2019-04-21 21:17:01 [INFO] Preparing start region
2019-04-21 21:17:01 [INFO] Done! For help, type "help" or "?"
2019-04-21 21:17:01 [INFO] CONSOLE: Forcing save..
2019-04-21 21:17:01 [INFO] CONSOLE: Save complete.
2019-04-21 21:17:01 [INFO] CONSOLE: Stopping the server..
2019-04-21 21:17:01 [INFO] CONSOLE: Stopping the server..
2019-04-21 21:17:01 [INFO] CONSOLE: Forcing save..
2019-04-21 21:17:01 [INFO] CONSOLE: Save complete.
2019-04-21 21:17:01 [INFO] CONSOLE: Stopping the server..
2019-04-21 21:17:01 [INFO] CONSOLE: Stopping the server..
2019-04-21 21:17:01 [INFO] CONSOLE: Forcing save..
2019-04-21 21:17:01 [INFO] CONSOLE: Save complete.
2019-04-21 21:17:01 [INFO] CONSOLE: Stopping the server..
2019-04-21 21:17:01 [INFO] CONSOLE: Stopping the server..
2019-04-21 21:17:01 [INFO] CONSOLE: Forcing save..
2019-04-21 21:17:01 [INFO] CONSOLE: Save complete.
2019-04-21 21:17:01 [INFO] CONSOLE: Stopping the server..
2019-04-21 21:17:01 [INFO] CONSOLE: Stopping the server..
2019-04-21 21:17:01 [INFO] CONSOLE: Forcing save..
2019-04-21 21:17:01 [INFO] CONSOLE: Save complete.
2019-04-21 21:17:01 [INFO] CONSOLE: Stopping the server..
2019-04-21 21:17:01 [INFO] Stopping server
2019-04-21 21:17:01 [INFO] Saving chunks
Morlok8k commented 5 years ago

the "-w" switch ignores [WARNING] and [SEVERE] messages.

VADemon commented 5 years ago

I know about -w but it's bad to ignore ALL errors.

Eventually I will publish my fork with enhancements or PR if you don't have sth. else planned. MLG worked nearly flawlessly so thx for that.