search

Morlok8k / MinecraftLandGenerator

Pregenerate Land in a SMP Minecraft Server
http://www.minecraftforum.net/topic/187737-minecraft-land-generator/
Do What The F*ck You Want To Public License
97 stars 20 forks source link

MLG violates multiple java naming conventions #2

Closed jaseg closed 11 years ago

jaseg commented 12 years ago

The packages are not named according to the Java Language Specification. Instead of morlok8k.minecraft.landgenerator and corrodias.minecraft.landgenerator it should rather be something like com.github.morlok8k.minecraft.landgenerator (according to the JLS Section 6.1 the package name should begin with just a reversed domain name of the software's author, in this case the github user subdomains would be an option). Furthermore the division between morlok8k.minecraft.landgenerator and corrodias.minecraft.landgenerator seems pretty arbitrary and unnecessary to me.

Most of the class names start with MLG_ which is unnecessary since java got packages. Time, Update and SelfAware would be OK.

Morlok8k commented 11 years ago

most of this has been fixed. It may not be exactly to the JLS, but its now much less unique.

This is the my first Java program, so a functioning program was the goal, not conforming to standards.