search

MorneTer / pwp-capstones

0 stars 0 forks source link

Summary #7

Open jmcrey opened 6 years ago

jmcrey commented 6 years ago

Rubric Score

Criteria 1: Valid Python Code

Criteria 2: Implementation of Project Requirements

Criteria 3: Software Architecture

Criteria 4: Uses Python Language Features

Overall Score: 16/16

This was a great project! My one piece of advice is to look into using universally acceptable child-class implementation syntax (covered here) and to check out more built-in functions for dictionaries (notably, the get function).

Otherwise, this project was very well implemented, followed Python's best practices, used spacing expertly and had descriptive variable names. Nice job!

MorneTer commented 6 years ago

Thank You Jeremiah for the level of detail and tips provided with your review! (it also felt really good reading it... haha. Thanks for the kind words)

Sincerely Morne Jeremiah McReynolds On Wed, Sep 12, 2018 at 5:13 AM Jeremiah McReynolds < notifications@github.com> wrote:

Rubric Score Criteria 1: Valid Python Code

  • Score Level: 4 (Exceeds Expectations)
  • Comment(s): Code runs without any errors.

Criteria 2: Implementation of Project Requirements

  • Score Level: 4 (Exceeds Expectations)
  • Comment(s): Code produces the suite of functions and classes required of it and calls them in an appropriate order. Furthermore, the code following Python's best practices, the code is well formatted, and is very cleverly implemented. Great job!

Criteria 3: Software Architecture

  • Score Level: 4 (Exceeds Expectations)
  • Comment(s): Code is separated into distinct classes and functions, each of which are invoked for their own purposes. Furthermore, the code under TomeRater produces a set of functions that further expand upon other functions, thereby allowing for code-reuse. Nice job!

Criteria 4: Uses Python Language Features

  • Score Level: 4 (Exceeds Expectations)
  • Comment(s): Code uses language features appropriately. If a task can be solved with a Python language feature, it is. Some highlights to this are the use of lambda throughout the last get_n_most* functions in the TomeRater class. Also, the use of sum and len in the get_average_rating under the Book class was absolutely sublime. The one exception is that we could have used the get function to help us in the add_book_to_user function (covered here https://github.com/MorneTer/pwp-capstones/issues/5); however, this was just a small oversight. The rest of the code was absolutely gorgeous.

Overall Score: 16/16

This was a great project! My one piece of advice is to look into using universally acceptable child-class implementation syntax (covered here https://github.com/MorneTer/pwp-capstones/issues/4) and to check out more built-in functions for dictionaries (notably, the get function).

Otherwise, this project was very well implemented, followed Python's best practices, used spacing expertly and had descriptive variable names. Nice job!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MorneTer/pwp-capstones/issues/7, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdN045HBqqjMZRPSutIVjNCng5fn97cks5uaHvDgaJpZM4WkkpL .