search

Morning-Train / toggl-api

GNU General Public License v3.0
34 stars 27 forks source link

Introduce coding standards (part1) #2

Closed derhasi closed 7 years ago

derhasi commented 7 years ago

I'd like to contribute to your project (e.g. add more documentation to the functions, improve error handling, provide specific classes as return values). But from my perspective this only can work well, when there are a coding standards defined. A widely adopted styleset is the Symfony Coding Standards.

With this PR I want to propose to switch to Symfony Coding Standards as coding standard.

The PR shall contain:

bjarnebonde commented 7 years ago

We appreciate your contributions 🙂

derhasi commented 7 years ago

@bjarnebonde thanks for merging. But ... I wasn't finished with the changes yet. I will open a new PR on monday to make the phpcs tests pass.

Can you add the project to Travis CI so, we the tests will run there? You can even add a Badge to the README for displaying the Travis CI status on the project page.

Rubatharisan commented 7 years ago

Hello @derhasi Thank you for your contributions - we will look into how to implement this project with TravisCI. I will see if I can get it done before the weekend :)