search

Morning-Train / toggl-api

GNU General Public License v3.0
34 stars 27 forks source link

Introduce coding standards (part2) #3

Closed derhasi closed 7 years ago

derhasi commented 7 years ago

As follow-up of #2 I also changed the rest of the coding style issues.

Rubatharisan commented 7 years ago

Hey @derhasi I added us to the Travis-CI.org, our page is https://travis-ci.org/Morning-Train/toggl-api Can you let me know if I set it up correctly? Is there anything I need to change?

Best regards, Ruba

derhasi commented 7 years ago

@Rubatharisan, looks like PR-checks are working.

When you enable "Build pushes" in settings you should also have checks for the master branch. The master branch would fail before merging this PR. but try it out, so you can see the CI run fail for master. And after merging the build should pass, like this PR does.

Rubatharisan commented 7 years ago

@derhasi How can I enable the checks for master branch? I can't see any options saying "Build master branch" or anything alike? It seems like I only can build pull requests.

image

Is this something I should enable in .travis.yml? Thank you for helping me out :)

derhasi commented 7 years ago

@Rubatharisan it is the "Build pushes" option, so any push to any branch will be tested (unless only specific branches are configured in the travis yml). But it will only take new pushes into account. So master will only build, when you push a new commit to master.

Rubatharisan commented 7 years ago

@derhasi ah okay that makes sense! I'll wait till a new commit appears :)

Thank you 👍

Rubatharisan commented 7 years ago

Have now reviewed the changes, will now merge this pull request, Thank you @derhasi for the changes!