Morning-Train / toggl-api

GNU General Public License v3.0
34 stars 27 forks source link

Fixed some little things #5

Closed ghost closed 7 years ago

Rubatharisan commented 7 years ago

Thank you for the changes eyeonx!

ghost commented 7 years ago

It's a pleasure :)

MohamedBoualleg commented 7 years ago

@Rubatharisan @eyeonx hey guys. Please be aware that the changes to the function name getDashboardForWorkspace() will break backward compatibility

Rubatharisan commented 7 years ago

Hey Mohamed, I agree - I have noted it under README - but is there anything different I can do to ensure backward compatibility?

Maybe: func.. getDashboadForWorkspace(){ getDashboardForWorkspace() }

Thank you Mohamed for your insight :)

MohamedBoualleg commented 7 years ago

@Rubatharisan what you proposed will solve the compatibility issue and it will be even better to mark the function a deprecated and then remove it in the next major release.

/**
 * @deprecated
 */
getDashboadForWorkspace(){
    getDashboardForWorkspace()
}

sorry for the late reply :)