MorningLit / pe

1 stars 0 forks source link

Incorrect response from result display? #6

Open MorningLit opened 3 years ago

MorningLit commented 3 years ago

image.png The title updated in index 1 does not correspond with the title in the result display

nus-se-bot commented 3 years ago

Team's Response

This is an expected behaviour. We are showing the last command that was undone in the command result.

For e.g., 1) if you update the title from "abc" to "1" 2) use undo command 3) The title will change from "1" to "abc" 4) The command result will display the command at step 1

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Sorry, maybe I should have been more clear about my response. But, I only brought up this issue because it was confusing for me as a user, when using undo and redo commands, the result message does not make sense logically.

image.png

  1. Initially, I create a case called 'konichiwa'.

image.png

  1. I update the case title to 'updated title'.

image.png

  1. I do an undo command, the response dialog box says the title was updated to "updated title" ? That's what I am understanding from the dialog box, when it is not. It is supposed to say that the title was updated to "konichiwa", unless your intended message was to show the title that was last updated, which was not shown very clearly here.

image.png

  1. When I do a redo command, the response dialog box says the title was updated to "updated title" which makes sense and is correct.

It seems that there is ambiguity in your undo and redo command result message, where undo is showing the title it is updated FROM, while redo is showing the title it is updated TO. Nevertheless, this can cause quite a lot of confusion and inconvenience to users. I suggest that you can fix this by sticking to one format for the messages or you could update the message to show the title being updated from the old title to the newer title or you could clarify it in the User Guide too.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: If you followed my flow of logic that I mentioned above, you would realise that this issue can cause occasional inconvenience to some users that rely heavily on undo and redo command, so please do reconsider my proposal. This is at least a low severity case and at most a medium severity case, depending on the type of user they are.