Closed Morningstar88 closed 6 years ago
@Microflow How about if I enlarge the thumbnail size to twice larger?
Current way is scale down the image to 64dp*64dp and put it in center of imageview. You could check dp converter for size reference.
Twice larger is good. Im wondering if Reddit scale down the thumbnail themselves, or if the image is scaled down by the app. If it can be doubled in size, and still look good, we can try that.
Aligning the thumbnail in the center of the page, over the text, will work for now.
Feel free to change the design according to your own intuition.
On 27 May 2018 at 07:49, Winston_Hung notifications@github.com wrote:
@Microflow https://github.com/Microflow How about if I enlarge the thumbnail size to twice larger?
Current way is scale down the image to 64dp*64dp and put it in center of imageview. You could check dp converter https://pixplicity.com/dp-px-converter for size reference.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Microflow/fforward-android/issues/1#issuecomment-392295160, or mute the thread https://github.com/notifications/unsubscribe-auth/AOslC_GSfp-vn99_z0TmYc_g2hj--DJWks5t2eoigaJpZM4UN9Rp .
Issue closed due to PR #12
This app will display a list of mealsharing, clothes-sharing and citizen trash collection links. For now, we will use the /r/art subreddit to fix the design.
This screenshot is a little large, but shows the fields that need to disappear.
Some fields need to be taken out, for a more minimal design.
Please remove the following fields:
And show how to remove these fields.
The following files may help:
Check lines 137-143
https://github.com/Microflow/buy-some-give-one-android/blob/2210513e4ae5ff062892f88811c843ce714c5fa1/src/main/java/org/quantumbadger/redreader/views/RedditPostHeaderView.java
General image info here:
https://github.com/Microflow/buy-some-give-one-android/tree/2210513e4ae5ff062892f88811c843ce714c5fa1/src/main/java/org/quantumbadger/redreader/image
Image views:
https://github.com/Microflow/buy-some-give-one-android/tree/2210513e4ae5ff062892f88811c843ce714c5fa1/src/main/java/org/quantumbadger/redreader/views/imageview
Maybe image size renderers here:
https://github.com/Microflow/buy-some-give-one-android/blob/2210513e4ae5ff062892f88811c843ce714c5fa1/src/main/java/org/quantumbadger/redreader/views/imageview/BoundsHelper.java
https://github.com/Microflow/buy-some-give-one-android/blob/2210513e4ae5ff062892f88811c843ce714c5fa1/src/main/java/org/quantumbadger/redreader/image/ThumbnailScaler.java