Moros1138 / PGEtinker

Interactively create an olcPixelGameEngine application from inside your browser!
https://www.pgetinker.com
37 stars 0 forks source link

Bug in Version: 8d6f9c6 #122

Closed TechnicJelle closed 2 months ago

TechnicJelle commented 3 months ago

Describe the bug The rename functionality of the code editor doesn't work.

To Reproduce Steps to reproduce the behaviour:

  1. Go to PGEtinker, the standard demo project is fine
  2. Right-click on the class name
  3. Click the "Rename symbol" button
  4. Type in a new name
  5. Press enter The text box popup disappears, but the symbol does not get renamed.

Expected behaviour The symbol gets properly renamed

Video

https://github.com/user-attachments/assets/82fba0b8-4638-4533-adf3-16d753a82993

Desktop:

Moros1138 commented 2 months ago

Good news! I found out why this was happening and found a solution. It turns out it was a problem with the language server. It had a C++ file in the project that it has been including in all of the information about state changes.. The "Rename Symbol" function tries to work on multiple files... the PGEtinker frontend only knows of 1 file.. the language server had 2 files in mind.. the problem magically went away when i removed the file from the language server's project!!

anyways, I'm trying to solve a visual problem with that input (the text is black, hard to read) ... before I push the changes to make that all work.