Morph21 / MercuryTrade-Community-Fork

An overlay application for Path of Exile(Tracking, Trading, Chat, etc)
MIT License
139 stars 24 forks source link

[BUG] - frequently stops popping up messages for outgoing and incoming traade requests #122

Closed dyfrgi closed 2 years ago

dyfrgi commented 2 years ago

After playing for a while, messages stop popping up. I haven't found a way to consistently trigger the bug, but once it starts it doesn't stop unless I restart MercuryTrade. That usually fixes the issue.

Here is an example outgoing log that didn't trigger a popup:

2022/06/02 14:54:19 956502984 cff9459d [INFO Client 34144] @To Tartinade: Hi, I would like to buy your Watcher's Eye Prismatic Jewel listed for 5 chaos in Sentinel (stash tab "~b/o 5 chaos"; position: left 7, top 20

And here is an incoming one:

2022/06/02 14:43:17 955841375 cff9459d [INFO Client 34144] @From Sanicx: Hi, I would like to buy your Inspired Learning Crimson Jewel listed for 2 exalted in Sentinel (stash tab "stuf"; position: left 10, top 1)
Morph21 commented 2 years ago

Did you get any errors in logs file? (should be in logs folder next to MercuryTrade.jar/exe)

orreuerro commented 2 years ago

Same bug and every time same error in log file: 2022-06-13 17:07:05.635 [Thread-5] ERROR ErrorHandler - java.lang.IllegalArgumentException at java.util.Date.parse(Unknown Source) at java.util.Date.(Unknown Source) at com.mercury.platform.core.utils.MessageFileHandler.lambda$parse$1(MessageFileHandler.java:81) at java.util.stream.ReferencePipeline$2$1.accept(Unknown Source) at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(Unknown Source) at java.util.stream.AbstractPipeline.copyInto(Unknown Source) at java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source) at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(Unknown Source) at java.util.stream.AbstractPipeline.evaluate(Unknown Source) at java.util.stream.ReferencePipeline.collect(Unknown Source) at com.mercury.platform.core.utils.MessageFileHandler.parse(MessageFileHandler.java:86) at com.mercury.platform.core.utils.FileMonitor$1.onFileChange(FileMonitor.java:43) at org.apache.commons.io.monitor.FileAlterationObserver.doMatch(FileAlterationObserver.java:412) at org.apache.commons.io.monitor.FileAlterationObserver.checkAndNotify(FileAlterationObserver.java:335) at org.apache.commons.io.monitor.FileAlterationObserver.checkAndNotify(FileAlterationObserver.java:305) at org.apache.commons.io.monitor.FileAlterationMonitor.run(FileAlterationMonitor.java:184) at java.lang.Thread.run(Unknown Source)

One thing different is [Thread-5], just using different number like [Thread-8] etc.

Morph21 commented 2 years ago

@orreuerro can you paste here an example message which produces that error which is recorded in Client.txt file?

orreuerro commented 2 years ago

@Morph21 this is the closest message to this error i could find: 2022/06/13 17:03:32 32858203 cff9459d [INFO Client 4968] @To SandySandWitch: Hi, I would like to buy your Ominous Construct Primeval Stalker Sentinel listed for 20 chaos in Sentinel (stash tab "Trade Sentinels"; position: left 11, top 1), after that there where no trade messages until after the bug has occured. At same time bug occured was this message: 2022/06/13 17:07:05 33071203 3796fecc [WARN Client 4968] Instant/Triggered action - Client failed to create aciton. 2022/06/13 17:07:05 33071203 3796fa2a [WARN Client 4968] Instant/Triggered actionwas serialized to the client, but the client failed to execute the action. skill_instance_id: 36866 action_id: 36624 object_id: 1079 target_id: 2027 flags: 129

Morph21 commented 2 years ago

@orreuerro sadly, I cannot reproduce that error. I tried yours and dyfrgi examples and they work for me :(

orreuerro commented 2 years ago

@Morph21 maybe its dx12 issue, and i think it only happens when i map etc., i'm sitting in hideout now for 3h without any errors and again same msg: 2022/06/15 20:33:57 31199953 3796fec6 [WARN Client 17836] Instant/Triggered action - Client failed to create aciton. 2022/06/15 20:33:57 31199953 3796fa20 [WARN Client 17836] Instant/Triggered actionwas serialized to the client, but the client failed to execute the action. and same error happened in mercurytrade at same time

Morph21 commented 2 years ago

2022/06/15 20:33:57 31199953 3796fec6 [WARN Client 17836] Instant/Triggered action - Client failed to create aciton.

that error is from path of exile so it can be because of dx12.

But MT not working is not related to dx12 since it "receives" messages from game only from that Client.txt file (It's the only way to get data from poe)

dyfrgi commented 2 years ago

Hmm so clearly it's happening when parsing a date, looking at that backtrace. So are the date formats in Client.txt somehow variable? Or maybe it's because of that multi-line log message. Can I get MercuryTrade to re-parse the file somehow? That would let us binary search our Client.txt for the cause.

koko-fox commented 2 years ago

Im into the same problem. I think collect only the lines starting with 20xx/xx/xx.