search

Morph21 / MercuryTrade-Community-Fork

An overlay application for Path of Exile(Tracking, Trading, Chat, etc)
MIT License
139 stars 24 forks source link

adjust currency regex to match current messages #150

Closed cscullen closed 1 year ago

cscullen commented 1 year ago

The original regex assumed messages would come in the form: Hi, I would like to buy your 430 Chaos Orb for my 2 Divine Orb in Crucible. offer

The 'offer' at the end being optional. However, lately most messages in game come in the form: Hi, I'd like to buy your 430 Chaos Orb for my 2 Divine Orb in Crucible

The regex would expect a period at the end of a trade offer so it could then search for the 'offer' group. Since new trade messages would not have a period, it would not match the PoeTradeCurrencyParser and instead try to match with PoeTradeItemParser. Leading to ??? appearing in the price window.

This change explicitely searches for 'offer' in a way that supports both message types.

cscullen commented 1 year ago

Addresses issue #147

Morph21 commented 1 year ago

H, did you test that change? I could merge this one and prepare new release but not sooner than after this weekend

cscullen commented 1 year ago

Yes, I have been playing with this change since posting.

Morph21 commented 1 year ago

Release posted few moments ago. Thank you for your help