search

Morpheox / Kraft

text-based iddle game
25 stars 22 forks source link

refactor tech #37

Closed zx13 closed 8 years ago

zx13 commented 8 years ago

It's ready, you should review first.

The diff isn't working so please follow these 3 bookmarks:

https://github.com/zx13/Kraft/blob/refactor/js/main.js#L1475 https://github.com/zx13/Kraft/blob/refactor/js/main.js#L2009 https://github.com/zx13/Kraft/blob/refactor/js/main.js#L4584

zx13 commented 8 years ago

@Morpheox I don't know why but the version freezes my browser tab. I tested it locally and it ran fine, it must be something special bout the web.. can you help investigate?

browser seems to complain about the save data i think. it failed on main.js line 1379 update(unlocked,JSON.parse(Cookies.get( 'unlocked')));

I reference this variable in my code so maybe I corrupted it?

nevermind, that JSON parse error was always there.. it does not matter I think.

My screen eventually unfroze after a few minutes. I think there is something in my code that is not performing fast so it lags for a minute on load

Morpheox commented 8 years ago

I dont know, now it doesnt work even when reverting.

2016-05-04 3:36 GMT+02:00 zx13 notifications@github.com:

@Morpheox https://github.com/Morpheox I don't know why but the version freezes my browser tab. I tested it locally and it ran fine, it must be something special bout the web.. can you help investigate?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/Morpheox/Kraft/pull/37#issuecomment-216717449