Morpheox / Kraft

text-based iddle game
25 stars 22 forks source link

[UI] The buttons don't have readable text. #72

Open SaphireLattice opened 7 years ago

SaphireLattice commented 7 years ago

I'm a fan of using dark themes practically everywhere. However it usually comes at a cost of some thing looking off, if not outright unuasable. That is sadly the case with this game.

Every <button> has the text same as background. The fix would be rather quick, just add two or four lines of CSS code.

Edit: On hover it's fine, but when not active, or when pressed down at, it looks like on the screenshot. Screenshot

Morpheox commented 7 years ago

Its working fine for most people, can you tell me what browser are you using'

SaphireLattice commented 7 years ago

Firefox on Linux. The thing is, <button>s are overriden by the GTK theme to have a dark color... but bootstrap (why is it even in?) overrides them to have black text without explicitly setting background white (aka it assumes button's background to be white, which is not correct in my case) and thus I get unreadable black-on-black buttons text.

Morpheox commented 7 years ago

Its your problem caused by using the in-game dark theme, or by using a browser-wide dark theme on the default white game theme?

SaphireLattice commented 7 years ago

Oh, whoops! Browser/Desktop Enviroment dark theme. And even when I enable the dark theme, I just get a even darker text color that I can actually read... On a still gray button, which is done by my browser/DE.