search

Morpho-lang / morpho

The Morpho language 🦋. Morpho is a small embeddable language for scientific computing applications.
MIT License
33 stars 11 forks source link

[Bug] Hydrogel refactor #174

Closed joshichaitanya3 closed 1 year ago

joshichaitanya3 commented 2 years ago

The Hydrogel speedup update to dev (#171) has an implementation of hydrogel_gradient assumes volume elements, which means the hydrogel functional currently wouldn't work in 2D. The idea is to have a functional_elementgradient method that would pick out the correct (area vs volume etc) gradient method, making such applications grade-independent.

Note that the existing Hydrogel gradient on the 0.5.4 release should work just fine.

joshichaitanya3 commented 2 years ago

This is fixed by #175 , right?

softmattertheory commented 1 year ago

@joshichaitanya3 Can you check this works on the latest /dev branch? If so, I'll close the issue.

joshichaitanya3 commented 1 year ago

All tests are passing on the latest dev!

softmattertheory commented 1 year ago

Amazing, we can close this!