search

MorrisB-- / MasterHash

Password manager that allows a user to have an almost infinite amount of passwords while only using their main one.
GNU General Public License v3.0
25 stars 41 forks source link

Generate password function #36

Open patanric opened 7 years ago

patanric commented 7 years ago

Implement a method that generates a password when the button in the NewLogin window is clicked. A simple password is ok. More sophisticated passwords could be done in a second step.

samsam1414 commented 7 years ago

Hi Riccardo! I'm interested in helping this project (very new to open source). I've taken a stab at this open issue and I'm curious if it's a good fit for the project.

One small issue though: when I click Generate, a new password is generated and populates in its associated field. But as you can see below, the password shows up as dots:

passwordfield

My thoughts are that this field should be changed from the PasswordField class to the standard TextField class. Maybe this would then allow the end user to copy the generated password and paste it into the website registration form he/she is filling out.

patanric commented 7 years ago

@bighandsam, welcome! :-) Yes, in my opinion we should go ahead with whatever improvement we think is appropriate. I like your solution.

sudk97 commented 7 years ago

As @bighandsam suggested for displaying the password generated, I have added an extra checkbox that allows the user to toggle between show/hide password. Also, after reviewing the earlier contributors' work, I have written a much shorter version of password generator that works somewhat similar. Please go through my code, and suggest any changes. Thank you. screenshot

jasm123 commented 7 years ago

Hi, Is this issue still open or closed?