search

MorrisB-- / MasterHash

Password manager that allows a user to have an almost infinite amount of passwords while only using their main one.
GNU General Public License v3.0
25 stars 41 forks source link

Enhance "Getting Started" part of README.md to guide users on how to import project to Eclipse. #5

Closed MorrisB-- closed 7 years ago

MorrisB-- commented 7 years ago

Doesn't have to be too detailed, maybe a simple link to something that shows new people where to download eclipse and how to import the project.

griffste commented 7 years ago

@MorrisB-- Hello I am looking to make my first Open Source contribution. I'd like to claim this if it is still available? Do I just need to add two links - one to download eclipse and one showing how to import the project to eclipse - to the README?

griffste commented 7 years ago

@MorrisB-- I submitted a pull request for this. Please let me know if there is anything I can change or improve.

https://github.com/MorrisB--/MasterHash/pull/9

MorrisB-- commented 7 years ago

Hello @griffste!

I just merged your request it looks great! However now that I look at it what do you think about combining the Getting Started and Eclipse section, since they're pretty similar? Let me know if you have any other suggestions!

Thanks, Morris

griffste commented 7 years ago

@MorrisB-- Sure I can combine them, whatever you think is best. I'll work on a new pull request now.

griffste commented 7 years ago

@MorrisB-- Let me know if you think this new pull request is better. I tried numbering the parts after "To Import to Eclipse" as 3 and 4, but markdown automatically switches them to 1 and 2 with the statement in between. If you want I can take out "To import..." statement and just have all four steps in a row. Just thought some people might use the code right on Git, so it would be better kind of separated. Let me know what you think

https://github.com/MorrisB--/MasterHash/pull/10

MorrisB-- commented 7 years ago

@griffste Looks great! Very well considered thanks for completing this!