fix compilation errors with GCC v14 - Githubissues

MorsGames / sm64plus

A fork of sm64-port that focuses on QoL improvements and customizability.

https://mfgg.net/index.php?act=resdb&param=02&c=2&id=38190

453 stars 32 forks source link

fix compilation errors with GCC v14 #101

Open Phytolizer opened 2 months ago

Phytolizer commented 2 months ago

GCC is promoting some warnings to errors in version 14. This PR fixes them in the simplest ways possible.

I am seeking feedback and alternative solutions to the fixes provided - these fixed my build but may break others.

Add pre-declarations for functions from src/game/camera.c (this won't affect behavior, but is required in the new version).
For the same reason, sys/stat.h is included in configfile.c (it is needed for the mkdir() call in configfile_save()).
The many (bool*) casts in configfile.c are because s8 * is no longer implicitly convertible to bool *.

Some notes:

SDL_MixAudioFormat arg cast seems like a bug. Maybe worth looking into rather than merging this as-is (which retains behavior).
Undefining __STRICT_ANSI__ as armips.cpp does is invalid in this version (it causes many errors), but I am not sure if behavior is preserved.